From: Wei Liu Date: Fri, 29 Apr 2016 15:11:14 +0000 (+0100) Subject: rombios/tcgbios: initialise logdataptr in HashLogEvent32 X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1151 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=0b5e769ae3ac81f8a8dfaf476147ccdf41caeb68;p=xen.git rombios/tcgbios: initialise logdataptr in HashLogEvent32 Gcc complains: tcgbios.c: In function ‘HashLogEvent32’: tcgbios.c:1131:10: error: ‘logdataptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] entry = tcpa_extend_acpi_log(logdataptr); It fails to figure out when logdataptr is used it is always initialised in a if block a few line above. Signed-off-by: Wei Liu Reviewed-by: Doug Goldstein Release-acked-by: Wei Liu --- diff --git a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c index 350105107c..fa22c4460a 100644 --- a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c +++ b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c @@ -1062,7 +1062,7 @@ uint32_t HashLogEvent32(struct hlei *hlei, struct hleo *hleo, { uint32_t rc = 0; uint16_t size; - uint32_t logdataptr; + uint32_t logdataptr = 0; uint32_t logdatalen; uint32_t hashdataptr; uint32_t hashdatalen;